linux-kernel - Re: [PATCH -next v2] bcache: use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7037a34e-988e-dbf5-9bed-e40f5e11c36b@suse.de>
Date:   Wed, 7 Apr 2021 17:49:56 +0800
From:   Coly Li <colyli@...e.de>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     Hulk Robot <hulkci@...wei.com>, kent.overstreet@...il.com,
        linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org
Subject: Re: [PATCH -next v2] bcache: use DEFINE_MUTEX() for mutex lock

On 4/7/21 5:38 PM, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX() rather
> than explicitly calling mutex_init().
> 
> this patch will reduce the size of bcache.ko about 64 bytes, the reason
> as follows:
> 
> though this patch will increase the size of .data segment about 32 bytes,
> it will also reduce the size of .init.text and .rodata.str1.1(at x86_64),
> .rodata_str1.8(at arm64) and .bss segment total about 96 bytes which reduce
>  the size more than .data segment;
> 

Thanks for the following information. BTW, the bss section should be
ignored, because they don't take physical file size.

It seems although the patched code has larger .data section, but the
generated code in .init.text and .rodata.str1.1(or 8) are much lesser
than the increased size. This is really interesting :-)

Your data is convinced, it is fair to take this patch in.

Could you please post a v3 version which removes the .bss information ?


Coly Li


> here is the statistics:
> Sections: (arm64 platform)
> Idx name		size
> -.init.text		00000240
> +.init.text		00000228
> 
> -.rodata.str1.8	000012cd
> +.rodata.str1.8	000012b5
> 
> -.data			00000c60
> +.data			00000c80
> 
> -.bss			00000080
> +.bss			00000060
> 
> Sections: (x86 platform)
> Idx name		size
> -.init.text		000001d9
> +.init.text		000001bf
> 
> -.rodata.str1.1	00000c80
> +.rodata.str1.1	00000c6d
> 
> -.data			00000cc0
> +.data			00000ce0
> 
> -.bss			00000080
> +.bss			00000070
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/md/bcache/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 03e1fe4de53d..3635f454309e 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
>  };
>  
>  static struct kobject *bcache_kobj;
> -struct mutex bch_register_lock;
> +DEFINE_MUTEX(bch_register_lock);
>  bool bcache_is_reboot;
>  LIST_HEAD(bch_cache_sets);
>  static LIST_HEAD(uncached_devices);
> @@ -2869,7 +2869,6 @@ static int __init bcache_init(void)
>  
>  	check_module_parameters();
>  
> -	mutex_init(&bch_register_lock);
>  	init_waitqueue_head(&unregister_wait);
>  	register_reboot_notifier(&reboot);
>  
>