linux-kernel - Re: [PATCH] char: tpm: fix error return code in tpm_cr50_i2c_tis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YG8v0hBVKxuVdEfT@kernel.org>
Date:   Thu, 8 Apr 2021 19:31:14 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Zhihao Cheng <chengzhihao1@...wei.com>
Cc:     peterhuewe@....de, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        yukuai3@...wei.com
Subject: Re: [PATCH] char: tpm: fix error return code in
 tpm_cr50_i2c_tis_recv()

On Thu, Apr 08, 2021 at 07:26:08PM +0800, Zhihao Cheng wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: 3a253caaad11 ("char: tpm: add i2c driver for cr50")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
> ---
>  drivers/char/tpm/tpm_tis_i2c_cr50.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index ec9a65e7887d..e908da78fbf4 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -483,6 +483,7 @@ static int tpm_cr50_i2c_tis_recv(struct tpm_chip *chip, u8 *buf, size_t buf_len)
>  	expected = be32_to_cpup((__be32 *)(buf + 2));
>  	if (expected > buf_len) {
>  		dev_err(&chip->dev, "Buffer too small to receive i2c data\n");
> +		rc = -EIO;
>  		goto out_err;
>  	}
>  
> -- 
> 2.25.4
> 

We are using E2BIG in similar situations in a few places:

❯ git grep E2BIG drivers/char/tpm
drivers/char/tpm/tpm-dev-common.c:              return -E2BIG;
drivers/char/tpm/tpm-interface.c:               return -E2BIG;
drivers/char/tpm/tpm_crb.c:             return -E2BIG;
drivers/char/tpm/tpm_i2c_atmel.c:               return -E2BIG;
drivers/char/tpm/tpm_i2c_infineon.c:            return -E2BIG;

So, I tend to think that also in here it'd be better to use E2BIG.

/Jarkko