linux-kernel - Re: [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 01:30:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Longfang Liu <liulongfang@...wei.com>, gregkh@...uxfoundation.org,
        mathias.nyman@...el.com, stern@...land.harvard.edu,
        liudongdong3@...wei.com
Cc:     kbuild-all@...ts.01.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, liulongfang@...wei.com,
        kong.kongxinwei@...ilicon.com, yisen.zhuang@...wei.com
Subject: Re: [PATCH v2 1/2] USB:ehci:Add a whitelist for EHCI controllers

Hi Longfang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v5.12-rc6 next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Longfang-Liu/USB-ehci-fix-the-no-SRBN-register-problem/20210408-215249
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-s022-20210408 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-279-g6d5d9b42-dirty
        # https://github.com/0day-ci/linux/commit/01b93fbbf8fb6137c7779062232c0fe8c1592940
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Longfang-Liu/USB-ehci-fix-the-no-SRBN-register-problem/20210408-215249
        git checkout 01b93fbbf8fb6137c7779062232c0fe8c1592940
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/usb/host/ehci-pci.c:57:10: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned short [usertype] vendor @@     got void * @@
   drivers/usb/host/ehci-pci.c:57:10: sparse:     expected unsigned short [usertype] vendor
   drivers/usb/host/ehci-pci.c:57:10: sparse:     got void *
>> drivers/usb/host/ehci-pci.c:57:16: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned short [usertype] device @@     got void * @@
   drivers/usb/host/ehci-pci.c:57:16: sparse:     expected unsigned short [usertype] device
   drivers/usb/host/ehci-pci.c:57:16: sparse:     got void *

vim +57 drivers/usb/host/ehci-pci.c

    49	
    50	static const struct usb_nosbrn_whitelist_entry {
    51		u16 vendor;
    52		u16 device;
    53	} usb_nosbrn_whitelist[] = {
    54		/* STMICRO ConneXT has no sbrn register */
    55		{PCI_VENDOR_ID_STMICRO, PCI_DEVICE_ID_STMICRO_USB_HOST},
    56		/* End of list */
  > 57		{NULL, NULL}
    58	};
    59	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32530 bytes)