linux-kernel - Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not just 2"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 13:45:50 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     George McCollister <george.mccollister@...il.com>
Cc:     Bryan Whitehead <bryan.whitehead@...rochip.com>,
        David S Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        netdev <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not
 just 2"

Hi George,

On Thu, Apr 8, 2021 at 1:36 PM George McCollister
<george.mccollister@...il.com> wrote:
>
> Can you explain the difference in behavior with what I was observing
> on the LAN7431?

I'm not using DSA in my application, so I cannot test or replicate
what you were observing. It would be great if we could work together
and settle on a solution that is acceptable to both of us.

> I'll retest but if this is reverted I'm going to start
> seeing 2 extra bytes on the end of frames and it's going to break DSA
> with the LAN7431 again.
>

Seen from my point of view, your patch is a regression. But perhaps my
patch set is a regression for you? Catch 22...

Would you be able to identify which patch broke your DSA behaviour?
Was it one of mine? Perhaps we can start from there.

Sven