linux-kernel - Re: [PATCH 13/13] tty: clean include/linux/tty.h up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG9CiV+CwGo2CFsN@kroah.com>
Date:   Thu, 8 Apr 2021 19:51:05 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH 13/13] tty: clean include/linux/tty.h up

On Thu, Apr 08, 2021 at 02:51:34PM +0200, Greg Kroah-Hartman wrote:
> There are a lot of tty-core-only functions that are listed in
> include/linux/tty.h.  Move them to drivers/tty/tty.h so that no one else
> can accidentally call them or think that they are public functions.
> 
> Cc: Jiri Slaby <jirislaby@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/tty/n_gsm.c  |  1 +
>  drivers/tty/n_hdlc.c |  1 +
>  drivers/tty/tty.h    | 37 +++++++++++++++++++++++++++++++++++++
>  include/linux/tty.h  | 34 ----------------------------------
>  4 files changed, 39 insertions(+), 34 deletions(-)

This needs a "tty.h" inclusion into drivers/tty/tty_baudrate.c,
otherwise it's a build warning, I missed that, sorry.  Will add that to
the next revision if it's needed, or just fix it up when committing it.

thanks,

greg k-h