linux-kernel - Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not just 2"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiX=9su1dpXPHzhT6sABDahbfEb_538J+j_MnV=Mj8PkDw@mail.gmail.com>
Date:   Thu, 8 Apr 2021 13:56:42 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Bryan Whitehead <bryan.whitehead@...rochip.com>,
        David S Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        George McCollister <george.mccollister@...il.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v1] Revert "lan743x: trim all 4 bytes of the FCS; not
 just 2"

Hi Heiner,

On Thu, Apr 8, 2021 at 1:49 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> Can't we use frame_length - ETH_FCS_LEN direcctly here?

If the hard-coded "4" refers to ETH_FCS_LEN, then yes, good point. I'd
love to find out first why George and I need different patches to make
the driver work in our use case, though.