[<prev] [next>] [day] [month] [year] [list]
Message-ID: <70873555-ab01-feb0-536b-d4b60ac89768@canonical.com>
Date: Thu, 8 Apr 2021 21:25:28 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: Arnd Bergmann <arnd@...nel.org>, DTML <devicetree@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>
Cc: Linus Walleij <linusw@...nel.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Alexandre Torgue <alexandre.torgue@...com>,
Kevin Hilman <khilman@...libre.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Tony Lindgren <tony@...mide.com>,
Shawn Guo <shawnguo@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
SoC Team <soc@...nel.org>,
Gregory Clement <gregory.clement@...tlin.com>,
Florian Fainelli <f.fainelli@...il.com>
Subject: Re: New 'make dtbs_check W=1' warnings
On 08/04/2021 17:08, Arnd Bergmann wrote:
> Greetings to all Arm platform maintainers,
>
> I've just gone through the DT merges I've received so far and, with a
> little help from Rob,
> managed to run 'make dtbs_check W=1' before and after, to see what
> warnings we get.
> The good news is that the number of warnings is going down, but
> unfortunately there
> is still an unmanageable amount of remaining warnings, and some new
> ones crept in.
>
> I'm still working on my tooling for this, to catch these better, but
> ideally I think we should
> try to not introduce new warnings. I think some platforms are already
> clean, and I did
> not see any new warnings for mvebu, samsung and broadcom. There were a lot of
> warnings from .dtsi files, and I probably did an incomplete job at
> deduplicating those.
>
> See below for the other platforms, and the new warnings that I found.
> If these are
> valid, please send a fixup before the merge window, and let me know if
> you have ideas
> for how we should handle these in the future.
>
> For this merge window, I don't think any of them are show-stoppers (Rob, let me
> know if you disagree), but in the long run we may want to gradually enforce
> a rule about not merging changes that introduce any new warnings, in order to
> have a chance of cleaning up the existing ones.
+1 for such rule, although the best would be to get a report about new
warnings on posted patches or shortly after applying, e.g. via 0-day
kbuild robot.
Best regards,
Krzysztof
Powered by blists - more mailing lists