linux-kernel - Re: [PATCH v3 12/12] kdump: Use vmlinux_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Apr 2021 12:58:24 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Baoquan He <bhe@...hat.com>, Petr Mladek <pmladek@...e.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Jessica Yu <jeyu@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Dave Young <dyoung@...hat.com>,
        Vivek Goyal <vgoyal@...hat.com>, kexec@...ts.infradead.org
Subject: Re: [PATCH v3 12/12] kdump: Use vmlinux_build_id to simplify

Quoting Baoquan He (2021-04-08 03:17:43)
> On 04/07/21 at 07:03pm, Petr Mladek wrote:
> > On Tue 2021-03-30 20:05:20, Stephen Boyd wrote:
> > > We can use the vmlinux_build_id array here now instead of open coding
> > > it. This mostly consolidates code.
> > > 
> > > Cc: Jiri Olsa <jolsa@...nel.org>
> > > Cc: Alexei Starovoitov <ast@...nel.org>
> > > Cc: Jessica Yu <jeyu@...nel.org>
> > > Cc: Evan Green <evgreen@...omium.org>
> > > Cc: Hsin-Yi Wang <hsinyi@...omium.org>
> > > Cc: Dave Young <dyoung@...hat.com>
> > > Cc: Baoquan He <bhe@...hat.com>
> > > Cc: Vivek Goyal <vgoyal@...hat.com>
> > > Cc: <kexec@...ts.infradead.org>
> > > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> > > ---
> > >  include/linux/crash_core.h |  6 +-----
> > >  kernel/crash_core.c        | 41 ++------------------------------------
> > >  2 files changed, 3 insertions(+), 44 deletions(-)
> > > 
> > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
> > > index 206bde8308b2..fb8ab99bb2ee 100644
> > > --- a/include/linux/crash_core.h
> > > +++ b/include/linux/crash_core.h
> > > @@ -39,7 +39,7 @@ phys_addr_t paddr_vmcoreinfo_note(void);
> > >  #define VMCOREINFO_OSRELEASE(value) \
> > >     vmcoreinfo_append_str("OSRELEASE=%s\n", value)
> > >  #define VMCOREINFO_BUILD_ID(value) \
> > > -   vmcoreinfo_append_str("BUILD-ID=%s\n", value)
> > > +   vmcoreinfo_append_str("BUILD-ID=%20phN\n", value)
> 
> I may miss something, wondering why we need add '20' here.

The build ID is an array of 20 bytes and this format is to print 20
bytes in hex.