linux-kernel - Re: [PATCH v1] ata: ahci_tegra: call tegra_powergate_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9f1a8dc-cf46-e501-606e-ce95f32b12d7@nvidia.com>
Date:   Thu, 8 Apr 2021 13:49:37 -0700
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>, <axboe@...nel.dk>,
        <thierry.reding@...il.com>
CC:     <jonathanh@...dia.com>, <linux-ide@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only
 when PM domain is not present


On 4/8/21 12:58 PM, Dmitry Osipenko wrote:
> 08.04.2021 19:40, Sowjanya Komatineni пишет:
>> This patch adds a check on present of PM domain and calls legacy power
>> domain API tegra_powergate_power_off() only when PM domain is not present.
>>
>> This is a follow-up patch to Tegra186 AHCI support patch series
>> https://lore.kernel.org/patchwork/cover/1408752/
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>
>>
>> ---
>>   drivers/ata/ahci_tegra.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
>> index 56612af..bd484dd 100644
>> --- a/drivers/ata/ahci_tegra.c
>> +++ b/drivers/ata/ahci_tegra.c
>> @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
>>   	reset_control_assert(tegra->sata_cold_rst);
>>   
>>   	clk_disable_unprepare(tegra->sata_clk);
>> -	tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>> +	if (!tegra->pdev->dev.pm_domain)
>> +		tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>>   
>>   	regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
>>   }
>>
> There are two instances of tegra_powergate_power_off() in the driver.
Thanks Dmitry. Sorry missed it. Will fix