linux-kernel - Re: [PATCH] KVM: SVM: Add support for KVM_SEV_SEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18c68409-5fcf-2f2c-61f2-e8e52aab277e@amd.com>
Date:   Thu, 8 Apr 2021 17:27:02 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Steve Rutherford <srutherford@...gle.com>, kvm@...r.kernel.org
Cc:     brijesh.singh@....com, linux-kernel@...r.kernel.org,
        natet@...gle.com, Ashish.Kalra@....com, pbonzini@...hat.com
Subject: Re: [PATCH] KVM: SVM: Add support for KVM_SEV_SEND_CANCEL command


On 4/1/21 8:44 PM, Steve Rutherford wrote:
> After completion of SEND_START, but before SEND_FINISH, the source VMM can
> issue the SEND_CANCEL command to stop a migration. This is necessary so
> that a cancelled migration can restart with a new target later.
>
> Signed-off-by: Steve Rutherford <srutherford@...gle.com>
> ---
>  .../virt/kvm/amd-memory-encryption.rst        |  9 +++++++
>  arch/x86/kvm/svm/sev.c                        | 24 +++++++++++++++++++
>  include/linux/psp-sev.h                       | 10 ++++++++
>  include/uapi/linux/kvm.h                      |  2 ++
>  4 files changed, 45 insertions(+)


Can we add a new case statement in sev_cmd_buffer_len()
[drivers/crypto/ccp/sev-dev.c] for this command ? I understand that the
command just contains the handle. I have found dyndbg very helpful. If
the command is not added in the sev_cmd_buffer_len() then we don't dump
the command buffer.

With that fixed.

Reviewed-by: Brijesh Singh <brijesh.singh@....com>