linux-kernel - Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG6kZDlCXs4MGHNw@kroah.com>
Date:   Thu, 8 Apr 2021 08:36:20 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Min Li <min.li.xe@...esas.com>
Cc:     "derek.kiernan@...inx.com" <derek.kiernan@...inx.com>,
        "dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support

On Wed, Apr 07, 2021 at 08:12:10PM +0000, Min Li wrote:
> > 
> > Why not use the miscdev name field?
> > 
> miscdev name field is just a char pointer and I need an static array to manipulate the name with index

Why?

> > So it's a parent?  Why not make this a real platform_device pointer and not
> > a device pointer?
> > 
> 
> It is not parent and mfd field is the parent

Then why are you saving it off?

> > What operations?
> > 
> 
> The MFD driver will create 2 devices, one is for phc driver and another one is this driver.
> The lock is to make sure these 2 driver's operations are synchronized. 

Ok, that should be documented a bit, it wasn't obvious :)

> > Index into what?
> > 
> 
> index is passed by mfd driver and will be used as part of device name such as "rsmu0"

So you can just look it up from the name?

thanks,

greg k-h