linux-kernel - Re: [PATCH 01/10] staging: rtl8188eu: remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG6wEDs2ZVPAOeUZ@kroah.com>
Date:   Thu, 8 Apr 2021 09:26:08 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] staging: rtl8188eu: remove unused macros

On Wed, Apr 07, 2021 at 07:05:22PM +0200, Martin Kaiser wrote:
> usb_ops_linux.h contains a couple of macros to make functions usable as
> urb completion callbacks. Most of them are unused and can be removed.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>  drivers/staging/rtl8188eu/include/usb_ops_linux.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> index 4e0e48cb5c8e..1a0b38de5027 100644
> --- a/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> +++ b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> @@ -23,18 +23,10 @@
>  #define USB_HIGH_SPEED_BULK_SIZE	512
>  #define USB_FULL_SPEED_BULK_SIZE	64
>  
> -#define _usbctrl_vendorreq_async_callback(urb, regs)	\
> -	_usbctrl_vendorreq_async_callback(urb)
> -#define usb_bulkout_zero_complete(purb, regs)		\
> -	usb_bulkout_zero_complete(purb)
> -#define usb_write_mem_complete(purb, regs)		\
> -	usb_write_mem_complete(purb)
>  #define usb_write_port_complete(purb, regs)		\
>  	usb_write_port_complete(purb)
>  #define usb_read_port_complete(purb, regs)		\
>  	usb_read_port_complete(purb)
> -#define usb_read_interrupt_complete(purb, regs)		\
> -	usb_read_interrupt_complete(purb)

Wow, that's there for a really old kernel version and should not be
needed anymore at all.  I'll take this, but please remove the other ones
here, they are not necessary.

thanks,

greg k-h