linux-kernel - Re: [PATCH] staging: rtl8712: removed unnecessary blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 10:37:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mitali Borkar <mitaliborkar810@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com, mitali_s@...iitr.ac.in
Subject: Re: [PATCH] staging: rtl8712: removed unnecessary blank line

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Apr 08, 2021 at 01:36:07PM +0530, Mitali Borkar wrote:
> Okay, should I rename the patch?

I can't take it as-is, so you need to change something :)

> I removed a line and matched alignment, so should I rename this
> appropriately?

Only do one logical thing per patch, so if this is 2 logical things,
then you need 2 patches, right?

thanks,

greg k-h