linux-kernel - Re: [PATCH] clk: fix for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CAHYREM5SP01.DM67S1LUC3NY@shaak>
Date:   Wed, 07 Apr 2021 21:50:15 -0400
From:   "Liam Beguin" <liambeguin@...il.com>
To:     "Stephen Boyd" <sboyd@...nel.org>,
        "Julia Lawall" <julia.lawall@...ia.fr>, <mturquette@...libre.com>
Cc:     <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <robh+dt@...nel.org>,
        <kbuild-all@...ts.01.org>
Subject: Re: [PATCH] clk: fix for_each_child.cocci warnings

Hi Stephen,

On Wed Apr 7, 2021 at 8:31 PM EDT, Stephen Boyd wrote:
> Quoting Julia Lawall (2021-04-07 12:02:32)
> > From: kernel test robot <lkp@...el.com>
> > 
> > For_each_child_of_node should have of_node_put() before goto.
> > 
> > Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> > 
> > CC: Liam Beguin <lvb@...hos.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
> > ---
>
> Is this a fix for a patch on the list?
>

This is a fix for a patch[1] I sent yesterday.
I'll apply and resend.

Thanks,
Liam

[1] https://patchwork.kernel.org/project/linux-clk/patch/20210407005330.2890430-2-liambeguin@gmail.com/

> > 
> > url:    https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
> > base:   f40ddce88593482919761f74910f42f4b84c004b
> > :::::: branch date: 9 hours ago
> > :::::: commit date: 9 hours ago
> > 
> >  clk-lmk04832.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/drivers/clk/clk-lmk04832.c
> > +++ b/drivers/clk/clk-lmk04832.c
> > @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
> >                 if (ret) {
> >                         dev_err(lmk->dev, "missing reg property in child: %s\n",
> >                                 child->full_name);
> > +                       of_node_put(child);
> >                         goto err_disable_oscin;
> >                 }
> >