linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2104081053200.5197@hadrien>
Date:   Thu, 8 Apr 2021 10:54:09 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
cc:     Greg KH <gregkh@...uxfoundation.org>,
        outreachy-kernel@...glegroups.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase
 in several files



On Thu, 8 Apr 2021, Fabio M. De Francesco wrote:

> On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote:
> > On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote:
> > > Remove camelcase in a symbol that is used by several files.
> >
> > What symbol?
> >
>
> I'm not sure I understand what you are asking. You mean
> that I have to specify the name of the variable that I changed?
> Or you mean that I shouldn't use the term "symbol" but write
> "variable", "function", "macro", and so on?

He wants the name of the symbol.  Each changed line includes lots of
symbols, so it is a significant effort to scan the patch to see what
symbol is being changed.

julia

>
> >
> > > --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
> > > +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
> > > @@ -203,7 +203,7 @@ struct pwrctrl_priv {
> > >  	u8 LpsIdleCount;
> > >  	u8 power_mgnt;
> > >  	u8 org_power_mgnt;
> > > -	u8 bFwCurrentInPSMode;
> > > +	u8 b_fw_current_in_ps_mode;
> >
> > The "b" here means "byte" so you can drop the "b_" as that means
> > nothing, we do not use this type of notation in the kernel as the
> > compiler can check it for us.
> >
>
> OK, I didn't know what the 'b' meant in this context. I'll drop it.
>
> Thanks,
>
> Fabio
>
> > thanks,
> >
> > greg k-h
> >
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2284292.R3b5UFg5HO%40localhost.localdomain.
>