linux-kernel - Re: [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 12:50:49 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     Kangjie Lu <kjlu@....edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-staging@...ts.linux.dev,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe

On Thu, Apr 8, 2021 at 11:19 AM Dinghao Liu <dinghao.liu@....edu.cn> wrote:
>
> When hmm_pool_register() fails, a pairing PM usage counter
> increment is needed to keep the counter balanced. It's the
> same for the following error paths.

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index 0295e2e32d79..02f774ed80c8 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -1815,6 +1815,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
>         hmm_cleanup();
>         hmm_pool_unregister(HMM_POOL_TYPE_RESERVED);
>  hmm_pool_fail:
> +       pm_runtime_get_noresume(&pdev->dev);
>         destroy_workqueue(isp->wdt_work_queue);
>  wdt_work_queue_fail:
>         atomisp_acc_cleanup(isp);
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko