linux-kernel - Re: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60b8e4d4-6baf-4106-b9e1-685652fb2163@amazon.com>
Date:   Thu, 8 Apr 2021 13:01:20 +0300
From:   "Shenhar, Talel" <talel@...zon.com>
To:     Ruiqi Gong <gongruiqi1@...wei.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
CC:     Wang Weiyang <wangweiyang2@...wei.com>, <linux-pm@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ronen Krupnik <ronenk@...zon.com>, <talelshenhar@...il.com>,
        <talel@...zon.com>
Subject: Re: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err
 call in thermal_mmio_probe()


On 4/8/2021 1:01 PM, Ruiqi Gong wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ruiqi Gong <gongruiqi1@...wei.com>
> ---
>   drivers/thermal/thermal_mmio.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
> index d0bdf1ea3331..ded1dd0d4ef7 100644
> --- a/drivers/thermal/thermal_mmio.c
> +++ b/drivers/thermal/thermal_mmio.c
> @@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
>
>          resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>          sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
> -       if (IS_ERR(sensor->mmio_base)) {
> -               dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
> -                       PTR_ERR(sensor->mmio_base));
> +       if (IS_ERR(sensor->mmio_base))
>                  return PTR_ERR(sensor->mmio_base);
> -       }
>
>          sensor_init_func = device_get_match_data(&pdev->dev);
>          if (sensor_init_func) {
Acked-by: Talel Shenhar <talel@...zon.com>