lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 8 Apr 2021 13:00:33 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Artur Petrosyan <Arthur.Petrosyan@...opsys.com>
Cc:     John Youn <John.Youn@...opsys.com>,
        Felipe Balbi <balbi@...nel.org>,
        Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mian Yousaf Kaukab <yousaf.kaukab@...el.com>,
        Gregory Herrero <gregory.herrero@...el.com>,
        Douglas Anderson <dianders@...omium.org>,
        Paul Zimmerman <paulz@...opsys.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Robert Baldyga <r.baldyga@...sung.com>,
        Kever Yang <kever.yang@...k-chips.com>
Subject: Re: [PATCH v2 00/14] usb: dwc2: Fix Partial Power down issues.

On Thu, Apr 08, 2021 at 10:09:20AM +0000, Artur Petrosyan wrote:
> Hi Greg,
> 
> On 4/8/2021 13:17, Artur Petrosyan wrote:
> > Hi Greg,
> > 
> > On 4/8/2021 11:28, Artur Petrosyan wrote:
> >> This patch set fixes and improves the Partial Power Down mode for
> >> dwc2 core.
> >> It adds support for the following cases
> >>       1. Entering and exiting partial power down when a port is
> >>          suspended, resumed, port reset is asserted.
> >>       2. Exiting the partial power down mode before removing driver.
> >>       3. Exiting partial power down in wakeup detected interrupt handler.
> >>       4. Exiting from partial power down mode when connector ID.
> >>          status changes to "connId B
> >>
> >> It updates and fixes the implementation of dwc2 entering and
> >> exiting partial power down mode when the system (PC) is suspended.
> >>
> >> The patch set also improves the implementation of function handlers
> >> for entering and exiting host or device partial power down.
> >>
> >> NOTE: This is the second patch set in the power saving mode fixes
> >> series.
> >> This patch set is part of multiple series and is continuation
> >> of the "usb: dwc2: Fix and improve power saving modes" patch set.
> >> (Patch set link: https://urldefense.com/v3/__https://marc.info/?l=linux-usb&m=160379622403975&w=2__;!!A4F2R9G_pg!IJ-Xl1ZwQU2kmqHB3ITyWyno9BgpWUsC647AqK7GIlgzJu9BzT6VN7jt--__fGdMtgWF69M$ ).
> >> The patches that were included in the "usb: dwc2:
> >> Fix and improve power saving modes" which was submitted
> >> earlier was too large and needed to be split up into
> >> smaller patch sets.
> >>
> >> Changes since V1:
> >> No changes in the patches or the source code.
> >> Sending the second version of the patch set because the first version
> >> was not received by vger.kernel.org.
> >>
> >>
> >>
> >> Artur Petrosyan (14):
> >>     usb: dwc2: Add device partial power down functions
> >>     usb: dwc2: Add host partial power down functions
> >>     usb: dwc2: Update enter and exit partial power down functions
> >>     usb: dwc2: Add partial power down exit flow in wakeup intr.
> >>     usb: dwc2: Update port suspend/resume function definitions.
> >>     usb: dwc2: Add enter partial power down when port is suspended
> >>     usb: dwc2: Add exit partial power down when port is resumed
> >>     usb: dwc2: Add exit partial power down when port reset is asserted
> >>     usb: dwc2: Add part. power down exit from
> >>       dwc2_conn_id_status_change().
> >>     usb: dwc2: Allow exit partial power down in urb enqueue
> >>     usb: dwc2: Fix session request interrupt handler
> >>     usb: dwc2: Update partial power down entering by system suspend
> >>     usb: dwc2: Fix partial power down exiting by system resume
> >>     usb: dwc2: Add exit partial power down before removing driver
> >>
> >>    drivers/usb/dwc2/core.c      | 113 ++-------
> >>    drivers/usb/dwc2/core.h      |  27 ++-
> >>    drivers/usb/dwc2/core_intr.c |  46 ++--
> >>    drivers/usb/dwc2/gadget.c    | 148 ++++++++++-
> >>    drivers/usb/dwc2/hcd.c       | 458 +++++++++++++++++++++++++----------
> >>    drivers/usb/dwc2/hw.h        |   1 +
> >>    drivers/usb/dwc2/platform.c  |  11 +-
> >>    7 files changed, 558 insertions(+), 246 deletions(-)
> >>
> >>
> >> base-commit: e9fcb07704fcef6fa6d0333fd2b3a62442eaf45b
> >>
> > 
> > Re sending as a "v2" did not work :(.
> > The patches are not in lore again.
> > 
> > Could the issue be with a comma in the end of To: or Cc: list?
> > Let me remove the comma in the end of those lists and try sending as "v3".
> > 
> > Regards,
> > Artur
> > 
> 
> I just removed the comma in the end of those lists and resent the patch 
> set as a "v3" and they are already seen in lore.
> There is one strange thing though on lore. Some patch titles are not 
> fully visible.
> 
> For sure the issue was comma in the end of To: or Cc: lists.
> Not working example.
> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
> linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,

That's an invalid To: line for email.

> Working example.
> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
> linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org

That's a correct line.

> If the comma is at least in the end of one of those lists (To: or Cc:) 
> vger.kernel.org mailing server will not accept them.

I recommend using 'git send-email' with the --to="foo@....com" type
options so that you don't have to hand-edit the lines to try to get
stuff like this correct, as it is easy to get wrong.

thanks,

greg k-h

Powered by blists - more mailing lists