[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210408111514.1011020-4-yukuai3@huawei.com>
Date: Thu, 8 Apr 2021 19:15:14 +0800
From: Yu Kuai <yukuai3@...wei.com>
To: <joern@...ybastard.org>, <miquel.raynal@...tlin.com>,
<richard@....at>, <vigneshr@...com>, <matthias.bgg@...il.com>
CC: <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>, <yukuai3@...wei.com>,
<yi.zhang@...wei.com>
Subject: [PATCH 3/3] mtd: phram: Fix error return code in phram_setup()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yu Kuai <yukuai3@...wei.com>
---
drivers/mtd/devices/phram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index 5b04ae6c3057..6ed6c51fac69 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -270,6 +270,7 @@ static int phram_setup(const char *val)
if (len == 0 || erasesize == 0 || erasesize > len
|| erasesize > UINT_MAX || rem) {
parse_err("illegal erasesize or len\n");
+ ret = -EINVAL;
goto error;
}
--
2.25.4
Powered by blists - more mailing lists