linux-kernel - Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 20:18:29 +0800
From:   luojiaxing <luojiaxing@...wei.com>
To:     Bart Van Assche <bvanassche@....org>, <jinpu.wang@...ud.ionos.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH v1 1/2] scsi: pm8001: clean up for white space


On 2021/4/8 5:56, Bart Van Assche wrote:
> On 4/5/21 11:39 PM, luojiaxing wrote:
>>
>> On 2021/4/3 0:01, Bart Van Assche wrote:
>>> On 4/2/21 2:08 AM, Luo Jiaxing wrote:
>>>>   #define AAP1_MEMMAP(r, c) \
>>>> -    (*(u32 *)((u8*)pm8001_ha->memoryMap.region[AAP1].virt_ptr + 
>>>> (r) * 32 \
>>>> +    (*(u32 *)((u8 *)pm8001_ha->memoryMap.region[AAP1].virt_ptr + 
>>>> (r) * 32 \
>>>>       + (c)))
>>> Since this macro is being modified, please convert it into an inline
>>> function such that the type of the arguments can be verified by the
>>> compiler.
>>
>> Sure, but still keep the function name as AAP1_MEMMAP?
>
> The coding style requires lower case names for functions so the 
> function name probably should be converted to lower case.


Sure, and sorry to post v2 before you reply, you can ignore it and 
directly check v3.


Thanks

Jiaxing


>
> Thanks,
>
> Bart.
>
> .
>