linux-kernel - Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG71iGoLHDxNgke4@orome.fritz.box>
Date:   Thu, 8 Apr 2021 14:22:32 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
        linux-pwm@...r.kernel.org, punit1.agrawal@...hiba.co.jp,
        devicetree@...r.kernel.org, yuji2.ishikawa@...hiba.co.jp,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        kernel@...gutronix.de, Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM
 support

On Thu, Apr 08, 2021 at 09:59:20AM +0200, Uwe Kleine-König wrote:
> Hello Nobuhiro,
> 
> On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote:
> > > > +	/*
> > > > +	 * pwmc is a 2-bit divider for the input clock running at 1 MHz.
> > > > +	 * When the settings of the PWM are modified, the new values are shadowed in hardware until
> > > > +	 * the period register (PCSR) is written and the currently running period is completed. This
> > > > +	 * way the hardware switches atomically from the old setting to the new.
> > > > +	 * Also, disabling the hardware completes the currently running period and keeps the output
> > > > +	 * at low level at all times.
> > > 
> > > Did you just copy my optimal description or is your hardware really that
> > > nice?
> > 
> > Yes, this hardware works as you wrote.
> > And I added about the state if the sinnal when this hardware disabled.
> > 
> > > 
> > > Do you know scripts/checkpatch.pl? I bet it will tell you to limit your
> > > lines to approx. 80 chars where sensible.
> > 
> > Yes, I know. I ran scripts/checkpatch.pl before send patch.
> > I understand that the number of characters per line has been changed to
> > 100 characters. Does the pwm driver recommend 80 characters?
> 
> For free-text comments I'd still recommend 80, yes. For code lines I'd
> be indeed more lax, as a line break in function calls reduces readability.

Let's not start making any special rules. It becomes impossible for
anyone to keep track of those. If checkpatch doesn't complain for
comments that exceed 80 characters, I will not reject based on that.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)