[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210408123913.f22o2k6qrjte5q2z@earth.universe>
Date: Thu, 8 Apr 2021 14:39:13 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc: Yang Yingliang <yangyingliang@...wei.com>,
linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH -next] power: supply: s3c_adc_battery: fix possible
use-after-free in s3c_adc_bat_remove()
Hi,
On Wed, Apr 07, 2021 at 01:15:11PM +0200, Krzysztof Kozlowski wrote:
> On 07/04/2021 11:19, Yang Yingliang wrote:
> > This driver's remove path calls cancel_delayed_work(). However, that
> > function does not wait until the work function finishes. This means
> > that the callback function may still be running after the driver's
> > remove function has finished, which would result in a use-after-free.
> >
> > Fix by calling cancel_delayed_work_sync(), which ensures that
> > the work is properly cancelled, no longer running, and unable
> > to re-schedule itself.
> >
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> > ---
> > drivers/power/supply/s3c_adc_battery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Thanks,
queued.
-- Sebastian
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists