[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210408125648.136519-1-lihuafei1@huawei.com>
Date: Thu, 8 Apr 2021 20:56:48 +0800
From: Li Huafei <lihuafei1@...wei.com>
To: <vigneshr@...com>, <tony@...mide.com>, <aaro.koskinen@....fi>
CC: <linux-omap@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <yangjihong1@...wei.com>,
<zhangjinhao2@...wei.com>, <--lihuafei1@...wei.com>
Subject: [PATCH -next] i2c: omap: fix PM reference leak in omap_i2c_probe()
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here. Fix
it by replacing it with pm_runtime_resume_and_get to keep usage counter
balanced.
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Li Huafei <lihuafei1@...wei.com>
---
drivers/i2c/busses/i2c-omap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 12ac4212aded..edbe498d49b8 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1404,7 +1404,7 @@ omap_i2c_probe(struct platform_device *pdev)
pm_runtime_set_autosuspend_delay(omap->dev, OMAP_I2C_PM_TIMEOUT);
pm_runtime_use_autosuspend(omap->dev);
- r = pm_runtime_get_sync(omap->dev);
+ r = pm_runtime_resume_and_get(omap->dev);
if (r < 0)
goto err_free_mem;
@@ -1525,7 +1525,7 @@ static int omap_i2c_remove(struct platform_device *pdev)
int ret;
i2c_del_adapter(&omap->adapter);
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0)
return ret;
--
2.17.1
Powered by blists - more mailing lists