linux-kernel - Re: [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820 integrity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e22b105449b6970177d5907d9cbb9e7f55bc72bb.camel@redhat.com>
Date:   Thu, 08 Apr 2021 09:01:51 -0400
From:   Simo Sorce <simo@...hat.com>
To:     Chris von Recklinghausen <crecklin@...hat.com>, ardb@...nel.org,
        rafael@...nel.org, decui@...rosoft.com, linux-pm@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/1] use crc32 instead of md5 for hibernation e820
 integrity check

On Thu, 2021-04-08 at 06:46 -0400, Chris von Recklinghausen wrote:
> Suspend fails on a system in fips mode because md5 is used for the e820
> integrity check and is not available. Use crc32 instead.
> 
> Prior to this patch, MD5 is used only to create a digest to ensure integrity of
> the region, no actual encryption is done. This patch set changes the integrity
> check to use crc32 instead of md5 since crc32 is available in both FIPS and
> non-FIPS modes.
> 
> Note that the digest is only used as an integrity check. No actual encryption
> is done.
> 
> Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
>        by md5 digest")
> 
> Tested-by: Dexuan Cui <decui@...rosoft.com>
> Reviewed-by: Dexuan Cui <decui@...rosoft.com>
> Signed-off-by: Chris von Recklinghausen <crecklin@...hat.com>

Hi Chris,
I would reword it this way:
----------
This patch(set) changes the integrity check algorithm from md5 to
crc32. This integrity check is used only to verify accidental
corruption of the hybernation data and is not intended as a
cryptographic integrity check.
Md5 is overkill in this case and also disabled in FIPS mode because it
is known to be broken for cryptographic purposes.
----------

HTH,
Simo.

-- 
Simo Sorce
RHEL Crypto Team
Red Hat, Inc