linux-kernel - Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a548e5c9-e579-6b82-88ea-e90a3378a74e@linux.microsoft.com>
Date:   Thu, 8 Apr 2021 09:26:28 -0400
From:   Vineeth Pillai <viremana@...ux.microsoft.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Michael Kelley <mikelley@...rosoft.com>
Cc:     Tianyu Lan <Tianyu.Lan@...rosoft.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        vkuznets <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Wei Liu <wei.liu@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        KY Srinivasan <kys@...rosoft.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
Subject: Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM


On 4/7/21 6:48 PM, Sean Christopherson wrote:
> On Wed, Apr 07, 2021, Michael Kelley wrote:
>>
>>> +		pr_info("Hyper-V nested_features: 0x%x\n",
>> Nit:  Most other similar lines put the colon in a different place:
>>
>> 		pr_info("Hyper-V: nested features 0x%x\n",
>>
>> One of these days, I'm going to fix the ones that don't follow this
>> pattern. :-)
> Any reason not to use pr_fmt?
Yes, that would be the best way to go. As Michael suggested,
it would be better to fix the whole file as a cleanup patch.
I shall fix this one to conform to the previous style and use
pr_fmt as a separate fixup patch.

Thanks,
Vineeth