linux-kernel - Re: [PATCH v3 08/14] usb: dwc2: Add exit partial power down when port reset is asserted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32f574b5-e433-e211-625f-48e261c50e91@synopsys.com>
Date:   Thu, 8 Apr 2021 13:39:58 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Artur Petrosyan <Arthur.Petrosyan@...opsys.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     John Youn <John.Youn@...opsys.com>
Subject: Re: [PATCH v3 08/14] usb: dwc2: Add exit partial power down when port
 reset is asserted

On 4/8/2021 1:45 PM, Artur Petrosyan wrote:
> Adds Partial Power Down exiting flow when set port feature
> reset is received in suspended state.
> 
> Signed-off-by: Artur Petrosyan <Arthur.Petrosyan@...opsys.com>

Acked-by: Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>

> ---
>   Changes in v3:
>   - None
>   Changes in v2:
>   - None
> 
>   drivers/usb/dwc2/hcd.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 720354df014b..7c7496719152 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -3694,6 +3694,15 @@ static int dwc2_hcd_hub_control(struct dwc2_hsotg *hsotg, u16 typereq,
>   			if (hsotg->params.power_down == DWC2_POWER_DOWN_PARAM_HIBERNATION &&
>   			    hsotg->hibernated)
>   				dwc2_exit_hibernation(hsotg, 0, 1, 1);
> +
> +			if (hsotg->in_ppd) {
> +				retval = dwc2_exit_partial_power_down(hsotg, 1,
> +								      true);
> +				if (retval)
> +					dev_err(hsotg->dev,
> +						"exit partial_power_down failed\n");
> +			}
> +
>   			hprt0 = dwc2_read_hprt0(hsotg);
>   			dev_dbg(hsotg->dev,
>   				"SetPortFeature - USB_PORT_FEAT_RESET\n");
>