linux-kernel - Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Apr 2021 16:53:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     liulongfang <liulongfang@...wei.com>
Cc:     mathias.nyman@...el.com, stern@...land.harvard.edu,
        liudongdong3@...wei.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, kong.kongxinwei@...ilicon.com,
        yisen.zhuang@...wei.com
Subject: Re: [PATCH 1/2] USB:ehci:Add a whitelist for EHCI controllers

On Thu, Apr 08, 2021 at 09:04:17PM +0800, liulongfang wrote:
> On 2021/4/8 17:22, Greg KH Wrote:
> > On Thu, Apr 08, 2021 at 05:11:12PM +0800, Longfang Liu wrote:
> >> Some types of EHCI controllers do not have SBRN registers.
> >> By comparing the white list, the operation of reading the SBRN
> >> registers is skipped.
> >>
> >> Subsequent EHCI controller types without SBRN registers can be
> >> directly added to the white list.
> >>
> >> The current patch does not affect the drive function.
> >>
> >> Signed-off-by: Longfang Liu <liulongfang@...wei.com>
> >> ---
> >>  drivers/usb/host/ehci-pci.c | 27 +++++++++++++++++++++++----
> >>  1 file changed, 23 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> >> index 3c3820a..6a30afa 100644
> >> --- a/drivers/usb/host/ehci-pci.c
> >> +++ b/drivers/usb/host/ehci-pci.c
> >> @@ -47,6 +47,28 @@ static inline bool is_bypassed_id(struct pci_dev *pdev)
> >>  	return !!pci_match_id(bypass_pci_id_table, pdev);
> >>  }
> >>  
> >> +static const struct usb_nosbrn_whitelist_entry {
> >> +	unsigned short vendor;
> >> +	unsigned short device;
> > 
> > u16 here please.
> > 
> >> +} usb_nosbrn_whitelist[] = {
> >> +	/* STMICRO ConneXT has no sbrn register */
> >> +	{PCI_VENDOR_ID_STMICRO, PCI_DEVICE_ID_STMICRO_USB_HOST},
> >> +	{}
> > 
> > trailing , please.
> > 
> 
> Is it necessary to add "," at the end here?

Yes please.