linux-kernel - RE: [PATCH 1/2] x86/traps: call cond_local_irq_disable before returning from exc_general_protection and math

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 13:08:55 +0000
From:   Thomas Tai <thomas.tai@...cle.com>
To:     Alexandre CHARTRE <alexandre.chartre@...cle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "x86@...nel.org" <x86@...nel.org>
CC:     "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "luto@...capital.net" <luto@...capital.net>,
        "jarkko@...nel.org" <jarkko@...nel.org>, "bp@...e.de" <bp@...e.de>,
        "jethro@...tanix.com" <jethro@...tanix.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] x86/traps: call cond_local_irq_disable before
 returning from exc_general_protection and math_error

> -----Original Message-----
> From: Alexandre CHARTRE <alexandre.chartre@...cle.com>
> Sent: April 9, 2021 5:06 AM
> To: Thomas Tai <thomas.tai@...cle.com>; tglx@...utronix.de;
> mingo@...hat.com; bp@...en8.de; x86@...nel.org
> Cc: sean.j.christopherson@...el.com; luto@...capital.net;
> jarkko@...nel.org; bp@...e.de; jethro@...tanix.com; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 1/2] x86/traps: call cond_local_irq_disable before
> returning from exc_general_protection and math_error
> 
> 
> On 4/8/21 7:28 PM, Thomas Tai wrote:
> > This fixes commit 334872a09198 ("x86/traps: Attempt to fixup
> exceptions
> > in vDSO before signaling") which added return statements without
> calling
> > cond_local_irq_disable(). According to commit ca4c6a9858c2
> > ("x86/traps: Make interrupt enable/disable symmetric in C code"),
> > cond_local_irq_disable() is needed because the ASM return code no
> > longer disables interrupts. Follow the existing code as an example to
> > use "goto exit" instead of "return" statement.
> >
> > Signed-off-by: Thomas Tai <thomas.tai@...cle.com>
> > ---
> >   arch/x86/kernel/traps.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> Reviewed-by: Alexandre Chartre <alexandre.chartre@...cle.com>

Thank you Alex.

Thomas

> 
> And it is probably worth adding a 'Fixes:' tag:
> 
> Fixes: 334872a09198 ("x86/traps: Attempt to fixup exceptions in vDSO
> before signaling")
> 
> alex.