linux-kernel - Re: [PATCHv2 35/38] dt-bindings: power: supply: ab8500: Convert to DT schema format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 15:43:15 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>
Subject: Re: [PATCHv2 35/38] dt-bindings: power: supply: ab8500: Convert to
 DT schema format

Hi Linus,

On Fri, Apr 09, 2021 at 01:28:05AM +0200, Linus Walleij wrote:
> On Wed, Mar 17, 2021 at 2:51 PM Sebastian Reichel
> <sebastian.reichel@...labora.com> wrote:
> 
> > Convert the binding to DT schema format.
> >
> > Note: The battery node does not have a compatible value and needs
> > to be described from the binding file for the PMIC. That has not
> > yet been converted, so I kept the information in plaintext for now.
> >
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> Thanks for doing this Sebastian:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks (I already merged this, though).

> Long term I want to get rid of the "charging algorithm" device node,
> as can be easily seen that is not a real hardware device but just
> some mockery to get a platform device up and probed. It is actually
> a library. But for now we need to keep it around.

Yes, the ab8500 charging algorithm obviously does not describe
hardware and should go away, just as charger-manager driver.
Optimally power-supply would provide a framework for this.

The battery node on the other hand does describe hardware (the raw
battery cells) and we have a common binding for this nowadays:

Documentation/devicetree/bindings/power/supply/battery.yaml

(At the moment it has neither properties for the chemistry nor
for temperature sensor position)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)