linux-kernel - Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

Open Source and information security mailing list archives

Message-ID: <449a323c-0bb3-a4aa-5a3f-1325fd4b802c@suse.de>
Date:   Fri, 9 Apr 2021 15:57:15 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Kevin Tang <kevin3.tang@...il.com>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        David Airlie <airlied@...ux.ie>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Orson Zhai <orsonzhai@...il.com>, Sean Paul <sean@...rly.run>
Subject: Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

Hi

Am 09.04.21 um 15:50 schrieb Kevin Tang:
>      > +static int __init sprd_drm_init(void)
>      > +{
>      > +     int ret;
> 
>     I think ret should just go away.
> 
> Like this?
> "return platform_register_drivers(sprd_drm_drivers, 
> ARRAY_SIZE(sprd_drm_drivers));"

Sure.

Best regards
Thomas

> if so, i will fix it, thks.
> 
> 
>     Acked-by: Thomas Zimmermann <tzimmermann@...e.de
>     <mailto:tzimmermann@...e.de>>
> 
>      > +
>      > +     ret = platform_register_drivers(sprd_drm_drivers,
>      > +                                     ARRAY_SIZE(sprd_drm_drivers));
>      > +     return ret;
>      > +}
>      > +
>      > +static void __exit sprd_drm_exit(void)
>      > +{
>      > +     platform_unregister_drivers(sprd_drm_drivers,
>      > +                                 ARRAY_SIZE(sprd_drm_drivers));
>      > +}
>      > +
>      > +module_init(sprd_drm_init);
>      > +module_exit(sprd_drm_exit);
>      > +
>      > +MODULE_AUTHOR("Leon He <leon.he@...soc.com
>     <mailto:leon.he@...soc.com>>");
>      > +MODULE_AUTHOR("Kevin Tang <kevin.tang@...soc.com
>     <mailto:kevin.tang@...soc.com>>");
>      > +MODULE_DESCRIPTION("Unisoc DRM KMS Master Driver");
>      > +MODULE_LICENSE("GPL v2");
>      > diff --git a/drivers/gpu/drm/sprd/sprd_drm.h
>     b/drivers/gpu/drm/sprd/sprd_drm.h
>      > new file mode 100644
>      > index 000000000..9781fd591
>      > --- /dev/null
>      > +++ b/drivers/gpu/drm/sprd/sprd_drm.h
>      > @@ -0,0 +1,16 @@
>      > +/* SPDX-License-Identifier: GPL-2.0 */
>      > +/*
>      > + * Copyright (C) 2020 Unisoc Inc.
>      > + */
>      > +
>      > +#ifndef _SPRD_DRM_H_
>      > +#define _SPRD_DRM_H_
>      > +
>      > +#include <drm/drm_atomic.h>
>      > +#include <drm/drm_print.h>
>      > +
>      > +struct sprd_drm {
>      > +     struct drm_device drm;
>      > +};
>      > +
>      > +#endif /* _SPRD_DRM_H_ */
>      >
> 
>     -- 
>     Thomas Zimmermann
>     Graphics Driver Developer
>     SUSE Software Solutions Germany GmbH
>     Maxfeldstr. 5, 90409 Nürnberg, Germany
>     (HRB 36809, AG Nürnberg)
>     Geschäftsführer: Felix Imendörffer
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives