linux-kernel - Re: [RFC PATCH 06/10] genirq: Don't mask IRQ within flow handler if IRQ is flow-masked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sg3z4l2v.ffs@nanos.tec.linutronix.de>
Date:   Fri, 09 Apr 2021 15:57:28 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Valentin Schneider <valentin.schneider@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     Marc Zyngier <maz@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Vincenzo Frascino <vincenzo.frascino@....com>
Subject: Re: [RFC PATCH 06/10] genirq: Don't mask IRQ within flow handler if IRQ is flow-masked

On Thu, Apr 08 2021 at 16:43, Valentin Schneider wrote:
> +	/*
> +	 * Masking is required if IRQ is ONESHOT and we can't rely on the
> +	 * flow-masking persisting down to irq_finalize_oneshot()
> +	 * (in the IRQ thread).
> +	 */
> +	if ((desc->istate & IRQS_ONESHOT) &&
> +	    (!(chip->flags & IRQCHIP_AUTOMASKS_FLOW) ||
> +	     !(chip->flags & IRQCHIP_EOI_THREADED)))

#define XXXX (IRQCHIP_AUTOMASKS_FLOW | IRQCHIP_EOI_THREADED)

        ((chip->flags & XXXX) != XXXX)

Hmm?

Thanks,

        tglx