linux-kernel - Re: [PATCH] USB: serial: do not use tty class device for debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 16:06:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: do not use tty class device for debugging

On Thu, Apr 08, 2021 at 05:08:59PM +0200, Johan Hovold wrote:
> Use the port struct device rather than tty class device for debugging.
> 
> Note that while USB serial doesn't support serdev yet (due to serdev not
> handling hotplugging), serdev ttys do not have a corresponding class
> device and would have been logged using a "(NULL device *):" prefix.
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/usb/serial/metro-usb.c  |  4 ++--
>  drivers/usb/serial/upd78f0730.c |  7 +++----
>  drivers/usb/serial/usb-serial.c | 32 ++++++++++++++++----------------
>  3 files changed, 21 insertions(+), 22 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>