linux-kernel - Re: [PATCH] ASoC: Intel: bytcr_wm5102: remove useless variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec10b000-34da-b4e8-8fa4-abb366557646@linux.intel.com>
Date:   Fri, 9 Apr 2021 10:37:29 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        cezary.rojewski@...el.com
Cc:     liam.r.girdwood@...ux.intel.com, yang.jie@...ux.intel.com,
        broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: Intel: bytcr_wm5102: remove useless variable



On 4/9/21 1:08 AM, Jiapeng Chong wrote:
> Fix the following gcc warning:
> 
> sound/soc/intel/boards/bytcr_wm5102.c:216:40: warning:
> ‘byt_wm5102_dai_params’ defined but not used.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Thanks for the patch.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
>   sound/soc/intel/boards/bytcr_wm5102.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/bytcr_wm5102.c b/sound/soc/intel/boards/bytcr_wm5102.c
> index f38850e..fd584e3 100644
> --- a/sound/soc/intel/boards/bytcr_wm5102.c
> +++ b/sound/soc/intel/boards/bytcr_wm5102.c
> @@ -213,14 +213,6 @@ static int byt_wm5102_init(struct snd_soc_pcm_runtime *runtime)
>   	return 0;
>   }
>   
> -static const struct snd_soc_pcm_stream byt_wm5102_dai_params = {
> -	.formats = SNDRV_PCM_FMTBIT_S16_LE,
> -	.rate_min = 48000,
> -	.rate_max = 48000,
> -	.channels_min = 2,
> -	.channels_max = 2,
> -};
> -
>   static int byt_wm5102_codec_fixup(struct snd_soc_pcm_runtime *rtd,
>   				  struct snd_pcm_hw_params *params)
>   {
>