linux-kernel - Re: [PATCH] ext4: Delete redundant uptodate check for buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YHCHF51vxFfujzNE@mit.edu>
Date:   Fri, 9 Apr 2021 12:55:51 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Ritesh Harjani <ritesh.list@...il.com>
Cc:     Shaokun Zhang <zhangshaokun@...ilicon.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yang Guo <guoyang2@...wei.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>
Subject: Re: [PATCH] ext4: Delete redundant uptodate check for buffer

On Thu, Apr 01, 2021 at 04:50:01PM +0530, Ritesh Harjani wrote:
> On 21/04/01 03:03PM, Shaokun Zhang wrote:
> > From: Yang Guo <guoyang2@...wei.com>
> >
> > The buffer uptodate state has been checked in function set_buffer_uptodate,
> > there is no need use buffer_uptodate before calling set_buffer_uptodate and
> > delete it.
> >
> > Cc: "Theodore Ts'o" <tytso@....edu>
> > Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> > Signed-off-by: Yang Guo <guoyang2@...wei.com>
> > Signed-off-by: Shaokun Zhang <zhangshaokun@...ilicon.com>
> > ---
> >  fs/ext4/inode.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> Thanks for the patch. Changes looks good and trivial.
> 
> Feel free to add -
> Reviewed-by: Ritesh Harjani <ritesh.list@...il.com>

Thanks, applied.

					- Ted