linux-kernel - Re: [PATCH 2/3] nvmem: eeprom: at25: add support for FRAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 10 Apr 2021 02:34:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiri Prchal <jiri.prchal@...ignal.cz>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Rob Herring <robh+dt@...nel.org>,
        Christian Eggers <ceggers@...i.de>,
        Jiri Prchal <jiri.prchal@...ignal.cz>
Subject: Re: [PATCH 2/3] nvmem: eeprom: at25: add support for FRAM

Hi Jiri,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next linux/master linus/master v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jiri-Prchal/nvmem-eeprom-add-support-for-FRAM/20210409-235546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git b195b20b7145bcae22ad261abc52d68336f5e913
config: arm64-randconfig-r033-20210409 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dd453a1389b6a7e6d9214b449d3c54981b1a89b6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/d335df5f35cd09d8f9d7f14e0bfbad45ab2bc33a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jiri-Prchal/nvmem-eeprom-add-support-for-FRAM/20210409-235546
        git checkout d335df5f35cd09d8f9d7f14e0bfbad45ab2bc33a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/eeprom/at25.c:169:59: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'int' [-Wformat]
           dev_dbg(&at25->spi->dev, "read %zu aux bytes --> %zd\n", len, status);
                                          ~~~                       ^~~
                                          %d
   include/linux/dev_printk.h:123:39: note: expanded from macro 'dev_dbg'
           dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                        ~~~     ^~~~~~~~~~~
   include/linux/dynamic_debug.h:162:19: note: expanded from macro 'dynamic_dev_dbg'
                              dev, fmt, ##__VA_ARGS__)
                                   ~~~    ^~~~~~~~~~~
   include/linux/dynamic_debug.h:147:56: note: expanded from macro '_dynamic_func_call'
           __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
                                                                 ^~~~~~~~~~~
   include/linux/dynamic_debug.h:129:15: note: expanded from macro '__dynamic_func_call'
                   func(&id, ##__VA_ARGS__);               \
                               ^~~~~~~~~~~
>> drivers/misc/eeprom/at25.c:169:64: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'int' [-Wformat]
           dev_dbg(&at25->spi->dev, "read %zu aux bytes --> %zd\n", len, status);
                                                            ~~~          ^~~~~~
                                                            %d
   include/linux/dev_printk.h:123:39: note: expanded from macro 'dev_dbg'
           dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
                                        ~~~     ^~~~~~~~~~~
   include/linux/dynamic_debug.h:162:19: note: expanded from macro 'dynamic_dev_dbg'
                              dev, fmt, ##__VA_ARGS__)
                                   ~~~    ^~~~~~~~~~~
   include/linux/dynamic_debug.h:147:56: note: expanded from macro '_dynamic_func_call'
           __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
                                                                 ^~~~~~~~~~~
   include/linux/dynamic_debug.h:129:15: note: expanded from macro '__dynamic_func_call'
                   func(&id, ##__VA_ARGS__);               \
                               ^~~~~~~~~~~
   2 warnings generated.


vim +169 drivers/misc/eeprom/at25.c

   144	
   145	/*
   146	 * read extra registers as ID or serial number
   147	 */
   148	static int fm25_aux_read(struct at25_data *at25, char *buf, uint8_t command,
   149				 int len)
   150	{
   151		int status;
   152		struct spi_transfer t[2];
   153		struct spi_message m;
   154	
   155		spi_message_init(&m);
   156		memset(t, 0, sizeof(t));
   157	
   158		t[0].tx_buf = &command;
   159		t[0].len = 1;
   160		spi_message_add_tail(&t[0], &m);
   161	
   162		t[1].rx_buf = buf;
   163		t[1].len = len;
   164		spi_message_add_tail(&t[1], &m);
   165	
   166		mutex_lock(&at25->lock);
   167	
   168		status = spi_sync(at25->spi, &m);
 > 169		dev_dbg(&at25->spi->dev, "read %zu aux bytes --> %zd\n", len, status);
   170	
   171		mutex_unlock(&at25->lock);
   172		return status;
   173	}
   174	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35507 bytes)