linux-kernel - Re: [PATCH v24 04/30] x86/cpufeatures: Introduce X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7a1299a-916f-70fe-6881-0951fe4fe38a@intel.com>
Date:   Fri, 9 Apr 2021 16:14:09 -0700
From:   "Yu, Yu-cheng" <yu-cheng.yu@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-mm@...ck.org,
        linux-arch@...r.kernel.org, linux-api@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Balbir Singh <bsingharora@...il.com>,
        Cyrill Gorcunov <gorcunov@...il.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Eugene Syromiatnikov <esyr@...hat.com>,
        Florian Weimer <fweimer@...hat.com>,
        "H.J. Lu" <hjl.tools@...il.com>, Jann Horn <jannh@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Kees Cook <keescook@...omium.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Nadav Amit <nadav.amit@...il.com>,
        Oleg Nesterov <oleg@...hat.com>, Pavel Machek <pavel@....cz>,
        Peter Zijlstra <peterz@...radead.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Vedvyas Shanbhogue <vedvyas.shanbhogue@...el.com>,
        Dave Martin <Dave.Martin@....com>,
        Weijiang Yang <weijiang.yang@...el.com>,
        Pengfei Xu <pengfei.xu@...el.com>,
        Haitao Huang <haitao.huang@...el.com>
Subject: Re: [PATCH v24 04/30] x86/cpufeatures: Introduce X86_FEATURE_CET and
 setup functions

On 4/9/2021 10:14 AM, Borislav Petkov wrote:
> On Fri, Apr 09, 2021 at 08:52:52AM -0700, Yu, Yu-cheng wrote:
>> Recall we had complicated code for the XSAVES features detection in
>> xstate.c.  Dave Hansen proposed the solution and then the whole thing
>> becomes simple.  Because of this flag, even when only the shadow stack is
>> available, the code handles it nicely.
> 
> Is that what you mean?
> 
> @@ -53,6 +55,8 @@ static short xsave_cpuid_features[] __initdata = {
>   	X86_FEATURE_INTEL_PT,
>   	X86_FEATURE_PKU,
>   	X86_FEATURE_ENQCMD,
> +	X86_FEATURE_CET, /* XFEATURE_CET_USER */
> +	X86_FEATURE_CET, /* XFEATURE_CET_KERNEL */
> 
> or what is the piece which becomes simpler?

Yes, this is it.

>> Would this equal to only CONFIG_X86_CET (one Kconfig option)?  In fact, when
>> you proposed only CONFIG_X86_CET, things became much simpler.
> 
> When you use CONFIG_X86_SHADOW_STACK instead, it should remain same
> simple no?
> 

Signals, arch_prctl, and ELF header are three places that need to depend 
on either shadow stack or IBT is configured.  To remain simple, we can 
make all three depend on CONFIG_X86_SHADOW_STACK, and in Kconfig, make 
CONFIG_X86_IBT depend on CONFIG_X86_SHADOW_STACK.  Without shadow stack, 
IBT itself is not as useful anyway.

>> Practically, IBT is not much in terms of code size.  Since we have already
>> separated the two, why don't we leave it as-is.  When people start using it
>> more, there will be more feedback, and we can decide if one Kconfig is
>> better?
> 
> Because when we add stuff to the kernel, we add the simplest and
> cleanest version possible and later, when we determine that additional
> functionality is needed, *then* we add it. Not the other way around.
> 
> Our Kconfig symbol space is already an abomination so we can't just add
> some more and decide later.
> 
> What happens in such situations usually is stuff gets added, it bitrots
> and some poor soul - very likely a maintainer who has to mop up after
> everybody - comes and cleans it up. I'd like to save myself that
> cleaning up.
> 
> Thx.
>