linux-kernel - Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Apr 2021 07:38:14 +0800
From:   angkery <angkery@....com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>
Cc:     axboe@...nel.dk, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org, Junlin Yang <yangjunlin@...ong.com>
Subject: Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than
 zero

On Fri, 9 Apr 2021 20:02:56 +0300
Sergei Shtylyov <sergei.shtylyov@...il.com> wrote:

> On 4/9/21 7:49 PM, Sergei Shtylyov wrote:
> 
> >> From: Junlin Yang <yangjunlin@...ong.com>
> >>
> >> The return from the call to platform_get_irq() is int, it can be
> >> a negative error code, however this is being assigned to an
> >> unsigned int variable 'irq', so making 'irq' an int, and change
> >> the position to keep the code format.
> >>
> >> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> >> WARNING: Unsigned expression compared with zero: irq > 0  
> > 
> >    I'd understand < 0... but > 0? What tool warned about this issue?
> >   
> > > yes, by coccicheck, i will update commits information.
> >
> >> Signed-off-by: Junlin Yang <yangjunlin@...ong.com>
> >> ---
> >>  drivers/ata/pata_ixp4xx_cf.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/ata/pata_ixp4xx_cf.c
> >> b/drivers/ata/pata_ixp4xx_cf.c index abc0e87..43215a4 100644
> >> --- a/drivers/ata/pata_ixp4xx_cf.c
> >> +++ b/drivers/ata/pata_ixp4xx_cf.c
> >> @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct
> >> ata_port *ap, 
> >>  static int ixp4xx_pata_probe(struct platform_device *pdev)
> >>  {
> >> -	unsigned int irq;  
> > 
> >    Oops, not sure how I missed that. :-/
> >    Thanks for fixing my overlook. :-)  
> 
>    Forgot to add my
> 
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...il.com>
> 
> > [...]  
> 
> MBR, Sergei