linux-kernel - Re: [PATCH] cifs: Remove useless variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mtmeMpkp=vAZYws7c7O+bXo-0XCmLLtNPLUYqV3rByqpA@mail.gmail.com>
Date:   Thu, 8 Apr 2021 23:09:47 -0500
From:   Steve French <smfrench@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: Remove useless variable

merged into cifs-2.6.git for-next

On Thu, Apr 8, 2021 at 3:33 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Fix the following gcc warning:
>
> fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used
> [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  fs/cifs/cifsacl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
> index d178cf8..fdb258a 100644
> --- a/fs/cifs/cifsacl.c
> +++ b/fs/cifs/cifsacl.c
> @@ -1094,11 +1094,9 @@ static int set_chmod_dacl(struct cifs_acl *pdacl, struct cifs_acl *pndacl,
>         struct cifs_ace *pnntace = NULL;
>         char *nacl_base = NULL;
>         u32 num_aces = 0;
> -       __u64 nmode;
>         bool new_aces_set = false;
>
>         /* Assuming that pndacl and pnmode are never NULL */
> -       nmode = *pnmode;
>         nacl_base = (char *)pndacl;
>         nsize = sizeof(struct cifs_acl);
>
> --
> 1.8.3.1
>


-- 
Thanks,

Steve