linux-kernel - Re: [PATCH] init/version.c: remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210408220508.c7ce7b1b90202a19223ed1f4@linux-foundation.org>
Date:   Thu, 8 Apr 2021 22:05:08 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     <christian.brauner@...ntu.com>, <masahiroy@...nel.org>,
        <ktkhai@...tuozzo.com>, <linux-kernel@...r.kernel.org>,
        "Zhiqi Song" <songzhiqi1@...wei.com>
Subject: Re: [PATCH] init/version.c: remove unused including
 <linux/version.h>

On Thu, 8 Apr 2021 14:26:58 +0800 Tian Tao <tiantao6@...ilicon.com> wrote:

> Remove including <linux/version.h> that don't need it.
> 

Um, how can version.c possibly not include version.h?

Sure, it may obtain access to version.h via some other include, but
that's plain luck and nonsense.  And it's unreliable and it requires
whichever-header-is-doing-this to continue to include version.h on
behalf of some .c file which should be including it directly!