linux-kernel - Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210409051613.GA4376@work>
Date:   Fri, 9 Apr 2021 10:46:13 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Laibin Qiu <qiulaibin@...wei.com>
Cc:     ulf.hansson@...aro.org, afaerber@...e.de, yuehaibing@...wei.com,
        linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log

On Fri, Apr 09, 2021 at 10:33:49AM +0800, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@...wei.com>

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks,
Mani

> ---
>  drivers/mmc/host/owl-mmc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 5490962dc8e5..3dc143b03939 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	owl_host->base = devm_ioremap_resource(&pdev->dev, res);
>  	if (IS_ERR(owl_host->base)) {
> -		dev_err(&pdev->dev, "Failed to remap registers\n");
>  		ret = PTR_ERR(owl_host->base);
>  		goto err_free_host;
>  	}
> -- 
> 2.25.1
>