linux-kernel - Re: [PATCH v3 2/2] scsi: pm8001: clean up for open brace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffEkc-aYgLR_UWZGoT51hvHaAOG2T-9FK=1ttjWMKUaLJ_Q@mail.gmail.com>
Date:   Fri, 9 Apr 2021 08:08:02 +0200
From:   Jinpu Wang <jinpu.wang@...os.com>
To:     Luo Jiaxing <luojiaxing@...wei.com>
Cc:     Jinpu Wang <jinpu.wang@...ud.ionos.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, linuxarm@...wei.com
Subject: Re: [PATCH v3 2/2] scsi: pm8001: clean up for open brace

On Thu, Apr 8, 2021 at 2:56 PM Luo Jiaxing <luojiaxing@...wei.com> wrote:
>
> There are few error about open brace is reported by checkpatch.pl:
>
> ERROR: that open brace { should be on the previous line
> +static struct error_fw flash_error_table[] =
> +{
>
> So fix them all.
>
> Signed-off-by: Jianqin Xie <xiejianqin@...ilicon.com>
> Signed-off-by: Luo Jiaxing <luojiaxing@...wei.com>
looks good to me, thx!
Acked-by: Jack Wang <jinpu.wang@...os.com>
> ---
>  drivers/scsi/pm8001/pm8001_ctl.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
> index 90b816f..8c253b0 100644
> --- a/drivers/scsi/pm8001/pm8001_ctl.c
> +++ b/drivers/scsi/pm8001/pm8001_ctl.c
> @@ -645,8 +645,7 @@ struct flash_command {
>       int     code;
>  };
>
> -static struct flash_command flash_command_table[] =
> -{
> +static const struct flash_command flash_command_table[] = {
>       {"set_nvmd",    FLASH_CMD_SET_NVMD},
>       {"update",      FLASH_CMD_UPDATE},
>       {"",            FLASH_CMD_NONE} /* Last entry should be NULL. */
> @@ -657,8 +656,7 @@ struct error_fw {
>       int     err_code;
>  };
>
> -static struct error_fw flash_error_table[] =
> -{
> +static const struct error_fw flash_error_table[] = {
>       {"Failed to open fw image file",  FAIL_OPEN_BIOS_FILE},
>       {"image header mismatch",         FLASH_UPDATE_HDR_ERR},
>       {"image offset mismatch",         FLASH_UPDATE_OFFSET_ERR},
> --
> 2.7.4
>