linux-kernel - Re: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPfvg1o1kTqm7=E6BmXe06=SwE413fqz=VDHnAGcfMW0ow@mail.gmail.com>
Date:   Fri, 9 Apr 2021 08:17:06 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Ye Weihua <yeweihua4@...wei.com>
Cc:     l.stelmach@...sung.com, mpm@...enic.com,
        herbert@...dor.apana.org.au,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        yangjihong1@...wei.com, zhangjinhao2@...wei.com
Subject: Re: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()

On Fri, 9 Apr 2021 at 08:11, Ye Weihua <yeweihua4@...wei.com> wrote:
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ye Weihua <yeweihua4@...wei.com>

Hi,

The same Lukasz' comment applies here as for Qinglang's patch from
November 2020 - resume also needs fix up.

Best regards,
Krzysztof