linux-kernel - Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 11:53:08 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Chen Hui <clare.chenhui@...wei.com>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org,
        mturquette@...libre.com, sboyd@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

On Thu, Apr 08, 2021 at 09:55:09PM +0800, Chen Hui wrote:
> Add missing MODULE_DEVICE_TABLE entries to support module autoloading,
> as these drivers can be compiled as external modules.
> 
> Signed-off-by: Chen Hui <clare.chenhui@...wei.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks,
Mani

> ---
>  drivers/clk/qcom/a53-pll.c      | 1 +
>  drivers/clk/qcom/a7-pll.c       | 1 +
>  drivers/clk/qcom/apss-ipq-pll.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c
> index 45cfc57bff92..af6ac17c7dae 100644
> --- a/drivers/clk/qcom/a53-pll.c
> +++ b/drivers/clk/qcom/a53-pll.c
> @@ -93,6 +93,7 @@ static const struct of_device_id qcom_a53pll_match_table[] = {
>  	{ .compatible = "qcom,msm8916-a53pll" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, qcom_a53pll_match_table);
>  
>  static struct platform_driver qcom_a53pll_driver = {
>  	.probe = qcom_a53pll_probe,
> diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c
> index e171d3caf2cf..c4a53e5db229 100644
> --- a/drivers/clk/qcom/a7-pll.c
> +++ b/drivers/clk/qcom/a7-pll.c
> @@ -86,6 +86,7 @@ static const struct of_device_id qcom_a7pll_match_table[] = {
>  	{ .compatible = "qcom,sdx55-a7pll" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, qcom_a7pll_match_table);
>  
>  static struct platform_driver qcom_a7pll_driver = {
>  	.probe = qcom_a7pll_probe,
> diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c
> index 30be87fb222a..bef7899ad0d6 100644
> --- a/drivers/clk/qcom/apss-ipq-pll.c
> +++ b/drivers/clk/qcom/apss-ipq-pll.c
> @@ -81,6 +81,7 @@ static const struct of_device_id apss_ipq_pll_match_table[] = {
>  	{ .compatible = "qcom,ipq6018-a53pll" },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table);
>  
>  static struct platform_driver apss_ipq_pll_driver = {
>  	.probe = apss_ipq_pll_probe,
> -- 
> 2.17.1
>