linux-kernel - Re: [PATCH] crypto: qat: Fix a double free in adf_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210409075520.GL31447@gondor.apana.org.au>
Date:   Fri, 9 Apr 2021 17:55:20 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Lv Yunlong <lyl2019@...l.ustc.edu.cn>
Cc:     giovanni.cabiddu@...el.com, davem@...emloft.net,
        andriy.shevchenko@...ux.intel.com, wojciech.ziemba@...el.com,
        fiona.trahe@...el.com, qat-linux@...el.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: qat: Fix a double free in adf_create_ring

On Fri, Apr 02, 2021 at 10:13:48AM -0700, Lv Yunlong wrote:
> In adf_create_ring, if the callee adf_init_ring() failed, the callee will
> free the ring->base_addr by dma_free_coherent() and return -EFAULT. Then
> adf_create_ring will goto err and the ring->base_addr will be freed again
> in adf_cleanup_ring().
> 
> My patch sets ring->base_addr to NULL after the first freed to avoid the
> double free.
> 
> Fixes: a672a9dc872ec ("crypto: qat - Intel(R) QAT transport code")
> Signed-off-by: Lv Yunlong <lyl2019@...l.ustc.edu.cn>
> ---
>  drivers/crypto/qat/qat_common/adf_transport.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt