linux-kernel - [kbuild] Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 11:35:12 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Xiaofei Tan <tanxiaofei@...wei.com>,
        gregkh@...uxfoundation.org, jirislaby@...nel.org
Cc:     lkp@...el.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, linuxarm@...neuler.org,
        Xiaofei Tan <tanxiaofei@...wei.com>
Subject: [kbuild] Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent
 should use tabs

Hi Xiaofei,

url:    https://github.com/0day-ci/linux/commits/Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git  tty-testing
config: x86_64-randconfig-m001-20210405 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
drivers/tty/sysrq.c:558 __sysrq_get_key_op() warn: curly braces intended?

vim +558 drivers/tty/sysrq.c

23cbedf812ff7c drivers/tty/sysrq.c  Emil Velikov    2020-05-13  549  static const struct sysrq_key_op *__sysrq_get_key_op(int key)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  550  {
23cbedf812ff7c drivers/tty/sysrq.c  Emil Velikov    2020-05-13  551  	const struct sysrq_key_op *op_p = NULL;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  552  	int i;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  553  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  554  	i = sysrq_key_table_key2index(key);
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  555  	if (i != -1)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  556  		op_p = sysrq_key_table[i];
97f5f0cd8cd0a0 drivers/char/sysrq.c Dmitry Torokhov 2010-03-21  557  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16 @558  		return op_p;
                                                                                ^^^^^^^^^^^
indented too far.

^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  559  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org 

Download attachment ".config.gz" of type "application/gzip" (39178 bytes)

_______________________________________________
kbuild mailing list -- kbuild@...ts.01.org
To unsubscribe send an email to kbuild-leave@...ts.01.org