linux-kernel - RE: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 08:55:40 +0000
From:   "Tan, Ley Foon" <ley.foon.tan@...el.com>
To:     Chen Hui <clare.chenhui@...wei.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>
CC:     "rfi@...ts.rocketboards.org" <rfi@...ts.rocketboards.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
 altera_msi_probe()



> -----Original Message-----
> From: Chen Hui <clare.chenhui@...wei.com>
> Sent: Friday, April 9, 2021 3:58 PM
> To: Tan, Ley Foon <ley.foon.tan@...el.com>; lorenzo.pieralisi@....com;
> robh@...nel.org; bhelgaas@...gle.com
> Cc: rfi@...ts.rocketboards.org; linux-pci@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
> altera_msi_probe()
> 
> There is a error message within devm_ioremap_resource already, so remove
> the dev_err call to avoid redundant error message.
> 
> Signed-off-by: Chen Hui <clare.chenhui@...wei.com>
> ---
>  drivers/pci/controller/pcie-altera-msi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-altera-msi.c
> b/drivers/pci/controller/pcie-altera-msi.c
> index 42691dd8ebef..98aa1dccc6e6 100644
> --- a/drivers/pci/controller/pcie-altera-msi.c
> +++ b/drivers/pci/controller/pcie-altera-msi.c
> @@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device
> *pdev)
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>  					   "vector_slave");
>  	msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(msi->vector_base)) {
> -		dev_err(&pdev->dev, "failed to map vector_slave
> memory\n");
> +	if (IS_ERR(msi->vector_base))
>  		return PTR_ERR(msi->vector_base);
> -	}
> 
>  	msi->vector_phy = res->start;
> 
> --


Reviewed-by: Ley Foon Tan <ley.foon.tan@...el.com>