[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <51e3225a-1abb-1c52-93cc-c6935f0c4b52@arm.com>
Date: Fri, 9 Apr 2021 14:42:39 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Wei Yongjun <weiyongjun1@...wei.com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Suzuki K Poulose <suzuki.poulose@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] coresight: trbe: Fix return value check in
arm_trbe_register_coresight_cpu()
On 4/9/21 6:52 AM, Wei Yongjun wrote:
> In case of error, the function devm_kasprintf() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.
Right.
>
> Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver")
Again, dont think this warrants "Fixes:" tag as there were no
functional problem to be fixed here.
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> drivers/hwtracing/coresight/coresight-trbe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c
> index 5ce239875c98..176868496879 100644
> --- a/drivers/hwtracing/coresight/coresight-trbe.c
> +++ b/drivers/hwtracing/coresight/coresight-trbe.c
> @@ -871,7 +871,7 @@ static void arm_trbe_register_coresight_cpu(struct trbe_drvdata *drvdata, int cp
>
> dev = &cpudata->drvdata->pdev->dev;
> desc.name = devm_kasprintf(dev, GFP_KERNEL, "trbe%d", cpu);
> - if (IS_ERR(desc.name))
> + if (!desc.name)
> goto cpu_clear;
>
> desc.type = CORESIGHT_DEV_TYPE_SINK;
>
LGTM.
Powered by blists - more mailing lists