linux-kernel - Re: [PATCH] tty: n_gsm: check error while registering tty devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 10:00:33 +0800
From:   Hao Sun <sunhao.th@...il.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
        Dmitry Vyukov <dvyukov@...gle.com>, jirislaby@...nel.org
Subject: Re: [PATCH] tty: n_gsm: check error while registering tty devices

> Can you share the info you know about the syzbot report?

Sorry for the late reply, I don't know the REPORT information of
syzbot because I haven't deployed it.
The attached reproduction program was generated by syz-repro.
As you can see from the repro.cprog, the bug occurred in the case of
fault injection.

In repro.cprog, line 108-109:
    inject_fault(81);
    syscall(__NR_ioctl, r[0], 0x5423, 0x20000080ul);


Hillf Danton <hdanton@...a.com> 于2021年4月7日周三 下午4:21写道：
>
> On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote:
> >
> >Yes, the fix makes sense.
>
> Thanks for taking a look.
>
> >But could you elaborate in the commit log when this happens?
> >I only wonder how real this is. I assume you inject faults to allocations?
>
> After looking at Hao's report [1] again, I think you are right as it was
> reported by syzbot too. Can you share the info you know about the syzbot
> report, Hao, something like the line below with the Reported-by prefix?
>
> (This is just an example     Reported-by: syzbot+b804f902bbb6bcf290cb@...kaller.appspotmail.com)
>
>
> [1] https://lore.kernel.org/lkml/CACkBjsYEhOuQUd2qjobumByFtAXyyoGqXgM8gXYZHqsnV8dgUg@mail.gmail.com/