linux-kernel - [PATCH 00/11] staging: rtl8723bs: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  9 Apr 2021 12:01:28 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Fabio Aiuto <fabioaiuto83@...il.com>,
        kernel test robot <lkp@...el.com>
Subject: [PATCH 00/11] staging: rtl8723bs: remove unused variables

This patchset fixes some issues warned from kernel test robot in reply
to the following patch:

https://lore.kernel.org/linux-staging/56055b20bc064d7ac1e8f14bd1ed42aba6b02c36.1617802415.git.fabioaiuto83@gmail.com/

This is kernel robot output:

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8723bs/core/rtw_cmd.c: In function 'rtw_cmd_thread':
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:390:16: warning: variable 'cmd_start_time' set but not used [-Wunused-but-set-variable]
     390 |  unsigned long cmd_start_time;
         |                ^~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/core/rtw_cmd.c:9:
   At top level:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^
--
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1136:6: warning: variable 'reason' set but not used [-Wunused-but-set-variable]
    1136 |  u16 reason;
         |      ^~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_dbg_port':
>> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2575:33: warning: variable 'preorder_ctrl' set but not used
+[-Wunused-but-set-variable]
    2575 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2601:33: warning: variable 'preorder_ctrl' set but not used
+[-Wunused-but-set-variable]
    2601 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   At top level:
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:36:27: warning: 'iw_operation_mode' defined but not used [-Wunused-const-variable=]
      36 | static const char * const iw_operation_mode[] = {
         |                           ^~~~~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:10:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^

First and fourth patch remove these two issues introduced by the patch above.

Other patches fix other local issues described in kernel test robot output
and other local 'make W=1' compiler warnings.

Unnecessary code blocks are removed as well.

Fabio Aiuto (11):
  staging: rtl8723bs: remove unused variable in core/rtw_cmd.c
  staging: rtl8723bs: remove unused variable and empty for cycles left
    unused in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused code block in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused variables and code block left unused
    in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove set but unused psta variable in
    rtw_dbg_port() in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused variable pstapriv in rtw_dbg_port()
    in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused cur_network variable in
    rtw_dbg_port() in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused pmlmepriv variable in rtw_dbg_port()
    in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove unused variable declaration in
    include/rtw_security.h
  staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c
  staging: rtl8723bs: remove decl of unused static const variable in
    os_dep/ioctl_linux.c

 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  3 --
 .../staging/rtl8723bs/include/rtw_security.h  | 18 --------
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 46 -------------------
 3 files changed, 67 deletions(-)

-- 
2.20.1