linux-kernel - Re: [PATCH] irqchip: fixed S3 could not resume after suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87k0pboi98.wl-maz@kernel.org>
Date:   Fri, 09 Apr 2021 11:38:11 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     414777006@...com
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        Mengguang Peng <pengmengguang@...tium.com.cn>
Subject: Re: [PATCH] irqchip: fixed S3 could not resume after suspend

On Fri, 09 Apr 2021 11:10:09 +0100,
414777006@...com wrote:
> 
> From: Mengguang Peng <pengmengguang@...tium.com.cn>
> 
> On arm64 platform, found that the machine could not wake up after suspend,
> this patch updates the its suspend and resume handling code.
> 
> - Add a variable named ctlr_save in struct rdists.
> - When suspend, save the value of GICR_CTLR to memmory
> 	in its_save_disable().
> - When resume, write the value of memory saved to GICR_CTLR
> 	in its_restore_enable().

This really is the kind of things that must be handled by firmware.
How comes yours doesn't handle it?

That is what you should be fixing. See the ATF code for a (working)
reference implementation

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.